Enable cop for pending rubocop-performance #102
Conversation
|
JFYI, Setting |
We are aware of that setting. But apparently we stopped enabling in the past when rubocop's cop shot us in the foot. But that was in 2020. Even if you changed to |
```
❯ bundle exec rubocop
Inspecting 42 files
.......................................C..
Offenses:
spec/spec_helper.rb:17:9: C: Performance/MethodObjectAsBlock: Use block explicitly instead of block-passing a method object.
.each(&method(:require))
^^^^^^^^^^^^^^^^^
42 files inspected, 1 offense detected
```
|
Thank you! As for always being on the edge we found it problematic, as new PRs could be constatnly blocked by new cops. This was delaying them indefinitely. Also, we had to ‘bundle update’ locally, and now we just happily live with an old version of RuboCop in Gemfile.lock. |
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).